Problems Packaging SolveSpace

Icosahunter

Hello, I'm trying to package SolveSpace and I'm having some issues. Everything seems to build fine until the very end where it make install doesn't work and I can't seem to get any more details on why. Here is my package.yml so far:

name : solvespace version : 3.1 release : 1 source : - git|https://github.com/solvespace/solvespace.git : v3.1 license : - GPL-3.0-or-later component : - office - mulitmedia.graphics summary : - SOLVESPACE is a free (GPLv3) parametric 3d CAD tool. description: | SOLVESPACE is a free (GPLv3) parametric 3d CAD tool. builddeps : - pkgconfig(cairo) - pkgconfig(libpng) - pkgconfig(zlib) - pkgconfig(json-c) - pkgconfig(freetype2) - pkgconfig(fontconfig) - pkgconfig(gtkmm-3.0) - pkgconfig(pangomm-1.4) - pkgconfig(glu) - pkgconfig(libglvnd) setup : | git submodule update --init extlib/libdxfrw extlib/mimalloc extlib/eigen build : | mkdir build cd build %cmake .. -DCMAKE_BUILD_TYPE=Release -DENABLE_OPENMP=ON %make install : | %make_install

The error I get is:

+ make install make: *** No rule to make target 'install'. Stop. Command '['/bin/bash', '--norc', '--noprofile', '/tmp/ypkg-installAc_Jp5']' returned non-zero exit status 2 [Build] install failed for solvespace Failed to build packages make: *** [../Makefile.common:17: build-stable] Error 1
Any help is appreciated, thanks!

algent

Icosahunter
You can try this:

name       : solvespace
version    : 3.1
release    : 1
source     :
    - git|https://github.com/solvespace/solvespace.git : v3.1
homepage   : https://solvespace.com/index.pl
license    : GPL-3.0-or-later
component  : multimedia.graphics
summary    : Parametric 2d/3d CAD 
description: |
    SOLVESPACE is a free (GPLv3) parametric 3d CAD tool.
builddeps  :
    - pkgconfig(cairo)
    - pkgconfig(libpng)
    - pkgconfig(zlib)
    - pkgconfig(json-c)
    - pkgconfig(freetype2)
    - pkgconfig(fontconfig)
    - pkgconfig(gtkmm-3.0)
    - pkgconfig(pangomm-1.4)
    - pkgconfig(glu)
    - pkgconfig(libglvnd)
setup      : |
    git submodule update --init extlib/libdxfrw extlib/mimalloc extlib/eigen
    mkdir build && cd build
    %cmake .. \
        -DCMAKE_BUILD_TYPE=Release \
        -DENABLE_OPENMP=ON
install    : |
    cd build
    %make_install

Icosahunter

algent Sweet, that worked! Being new to packaging, I have a few questions:

Why is there no build section? Is "make" implied in the build section if one is omitted or something?
Did you put cmake in setup because it generates the makefile as opposed to actually doing any compiling?
Why do we need to cd into build in install step?
Do we have to do the submodule update call for any repo that has submodules or is there something peculiar to Solvespace's setup that requires that? I saw another thread about submodules in packaging that didn't mention the update call so I wasn't sure if using the git| automatically handled submodules or not.
Thanks!

algent

Icosahunter

Why is there no build section? Is "make" implied in the build section if one is omitted or something?

I just guessed. No idea why it worked.
But looks like this is the way to package it.

setup      : |
    mkdir build && cd build
    %cmake .. \
        -DCMAKE_BUILD_TYPE=Release \
        -DENABLE_OPENMP=ON
build      : |
    cd build
    %make
install    : |
    cd build
    %make_install

Why do we need to cd into build in install step?

I don't know, I am not a developer. I am a packager and this setup with build folder is very common.

There is a more efficient way of packaging with our ninja macros, if a build folder is needed. Also removed git submodule update, and it worked:

setup      : |
    %cmake_ninja -DCMAKE_BUILD_TYPE=Release -DENABLE_OPENMP=ON
build      : |
    %ninja_build
install    : |
    %ninja_install

Icosahunter

algent I see, thanks for the info!