• Development
  • Update of protonvpn-cli to its new version: inclusion of pythondialog required

Hello,
A while ago, I proposed to update protonvpn-cli to its new version, available in this repo. It was accepted by the community (see T8511).

As such, I started working on a new package. Unfortunately, this new version of protonvpn needed to include the pythondialog python library. I made a package proposal for it, which was accepted as it is a dependency of an approved package (see T8512).

Later, I started to build a package for pythondialog, named python-pythondialog. I sent my patches on the dev tracker (see D7737). I was quite happy with my changes, I even managed to get the new protonvpn working on my own computer!

However, it is still not accepted, the only comment is from @JoshStrobl, quoting:

And what is this for? Tasks should be referenced.

My next comment explained the situation as much as possible. I did my very best to be clear, but got no answer.

I am not blaming anyone in this post. I'd like to know what I've done wrong. Can someone explain me? What changes are needed in order to make this patch accepted?

Thanks for your answer. I wasn't aware it was needed. Fixed it!