Packaging problems

Alexandru-Balan

Hi, I am trying to package a program for solus and I have a major problem I can't solve.
make -f release.makefile -e PREFIX=$installdir
Why does the above command NOT work when I type make, but if I chroot in the package environment and run it manually it does?

Edit: I've tried solbuild delete-cache -a and then rebuilding the package

Alexandru-Balan

It was because it was running two commands:
mkdir -p build && cd build and then make -j -C build meaning that before compilation it was trying to go into a new build sub-directory which was nonexistent

kyrios

Alexandru-Balan You have to specify the number of jobs after the -j option or it doesn't make sense.
By the way, you have to use the actionable macro %make that will set this option for you so basically all you have to do is :
%make -C build

Alexandru-Balan

kyrios I think that -j without a number is used when you want to run as many jobs as possible. Also %make as I understand it is using DESTDIR, but for some reason that doesn't work as the install path is always overwritten by this PREFIX variable

JoshStrobl

Alexandru-Balan

without a number is used when you want to run as many jobs as possible

Not, with a specific number it defaults to 1 job.

Also %make as I understand it is using DESTDIR,

No, %make sets the job count to maximum allowed. It doesn't set DESTDIR.

but for some reason that doesn't work as the install path is always overwritten by this PREFIX variable

Not if it is any remotely sensible Makefile, it doesn't. It'll use DESTDIR and PREFIX, e.g. $(DESTDIR)$(PREFIX)

Our %make_install actionable macro is what sets DESTDIR. PREFIX defaults to /usr unless otherwise set by the Makefile.

You can see our actionable macros here.

Alexandru-Balan

JoshStrobl Not if it is any remotely sensible Makefile

Not really. It uses only PREFIX

JoshStrobl %make sets the job count to maximum allowed. It doesn't set DESTDIR.

Got it now, thanks

JoshStrobl Not, with a specific number it defaults to 1 job.

Not as per the gnu make documentation. Also I can attest that is using more than 1 job when building

tomocafe

Alexandru-Balan

Alexandru-Balan Not as per the gnu make documentation. Also I can attest that is using more than 1 job when building

I can also attest to this. We used to have a build script that took an argument for the number of threads, like make -j $1. But if you forgot to give an argument, $1 would expand to an empty string and it would just call make -j. That would paralyze the build server. Trashing and swapping galore. (Note: it runs in parallel as many jobs as it can parallelize, which for a large project can be a lot of jobs. I wish they’d change it to cap at how many cores you have on your machine.)

The (bash) fix was to use make ${1:+-j $1} 😉