Atom update to v1.40.1 breaks git-diff (and Atom generally freezes)

FunkyloverOne

I don't know if it is actually Atom's issue, or there's something wrong on Solus side, but I didn't see any such GitHub issues posted on Atom's repo, so I decided to post it here first. 😅

So the issue is that atom no more highlights anything git-related, kinda fails to figure out that it actually works with a git repo. Meanwhile, I have rolled back my last Solus upgrade, so my atom is now v1.39.0 and git-related highlighting is back.

Also, I would like to report that I'm facing stability issues with Atom, for about a month by now. So when I click RMB anywhere inside Atom, it may randomly freeze the system, and I have to reset it.

Jacalz

I am the one who maintaines the atom updates for the most part and I haven't noticed these issues on any of my machines yet...

FunkyloverOne

Jacalz well, perhaps freezes are related to my hardware. The thing is though, I do not have any such issues with any other apps.
On my work machine, it's just Ryzen 3 2200g APU, works on integrated graphics, on top of GIGABYTE B450M DS3H (rev. 1.0) Motherboard, with latest BIOS version (F42b as of 2019/07/31). I did that BIOS update recently, as I hoped it might stop those freezes, but no success there.

ki3lich

I had the same problem with git-diff and git-plus. Downgrading to v1.39.0 fixed problem.

Jacalz

I'm sorry but this just ain't something I can replicate 🙄

FunkyloverOne

Jacalz well, no problem, that's just extra info. The main issue here is git-diff issues after an update.

JoshStrobl

I would suggest filing your issue with the Atom developers: https://github.com/atom/atom

FunkyloverOne

JoshStrobl I will wait for the next release just in case for now. If it still won't be fixed, I will fill my issue there.
@javan-z meanwhile I've tested it on a completely different machine (Acer laptop with an Intel i3 CPU), and it has the same issue.

FunkyloverOne

Newer release v1.40.1-126 has git-related issues fixed.

Also, I guess, my stability issues were caused by my forced low amount of RAM reserved for integrated graphics in BIOS 😃

JoshStrobl

FunkyloverOne Newer release v1.40.1-126 has git-related issues fixed.

Yea that's because I fixed it 😛

FunkyloverOne

JoshStrobl I suspected that 😀 just letting everyone know.

BTW, it seems strange that I cannot mark this post anyhow. You know, like put "RESOLVED" word somewhere at the top...

Staudey

FunkyloverOne Only mods can change the tags of a post (at least as soon as someone else has posted in that thread)

JoshStrobl

Yea I could probably loosen up the permission requirements on some of it. When I initially set it up I wanted to err on the side of caution but unsurprisingly our community has been sensible with the usage of available tags.

FunkyloverOne

Hey @JoshStrobl, there's still something wrong with the new release though.

It silently errors (you gotta Toggle Developer Tools), and it just does not Search in Folder anymore. An error seems to be also git-related.

But I guess, it will be all good with the release of v1.41, right?

P.S. this post is not Solved anymore 😬

FunkyloverOne

Guys, so I have just installed the latest Atom release v1.41.0-127, and unfortunately search in folder still does not work, it simply stuck on this:

and has some git-related errors in a console.
At the moment of testing that I had all the Solus packages up to date, and did a reboot after an update.

@Jacalz ping

Jacalz

Could you post the errors that you see in the console. I just tested on my second computer and it works perfectly fine on that one as well for me. Will look a bit further in to it if I can find anything else.

FunkyloverOne

Jacalz here we go, this one goes first:

<embedded>:14 

/usr/share/atom/resources/app.asar.unpacked/node_modules/scandal/node_modules/git-utils/build/Release/git.node: undefined symbol: git_net_url_is_default_port Error: /usr/share/atom/resources/app.asar.unpacked/node_modules/scandal/node_modules/git-utils/build/Release/git.node: undefined symbol: git_net_url_is_default_port
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:160:31)
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:722:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:169:18)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/node_modules/git-utils/src/git.js:3:22)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/node_modules/git-utils/src/git.js:358:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:255:23)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/lib/path-filter.js:6:14)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/lib/path-filter.js:275:4)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/lib/path-filter.js:277:3)
    at Module._compile (internal/modules/cjs/loader.js:693:30)
    at Object.value [as .js] (/usr/share/atom/resources/app.asar/src/compile-cache.js:255:23)
    at Module.load (internal/modules/cjs/loader.js:602:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:541:12)
    at Function.Module._load (internal/modules/cjs/loader.js:533:3)
    at Module.require (internal/modules/cjs/loader.js:640:17)
    at require (internal/modules/cjs/helpers.js:20:18)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/lib/path-scanner.js:12:16)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/lib/path-scanner.js:127:4)
    at Object.<anonymous> (/usr/share/atom/resources/app.asar/node_modules/scandal/lib/path-scanner.js:129:3)

And this is a second one:

    <embedded>:14
    
    handler is not defined ReferenceError: handler is not defined
    at process.<anonymous> (/usr/share/atom/resources/app.asar/src/task-bootstrap.js:69:20)
    at process.emit (events.js:182:13)
    at emit (internal/child_process.js:812:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

And here is how to reproduce it:

Jacalz

I can't replicate the errors, but I see that search in folder isn't working. Will have too look in to this more when I get some time, but the latest updated did at least fix ctrl + p for me. It was broken before, but got fixed for me with my patch.

JoshStrobl

Meanwhile it worked fine for me with my patch and is no different with yours.

FunkyloverOne

@Jacalz JoshStrobl Guys, I guess my good old atom v1.39.0 is now missing from your repositories.

I am checking for it here: https://mirrors.rit.edu/solus/packages/shannon/a/atom/
Maybe I just don't know something 🙂

Anyway, could you give me a command to install that particular version if it's still possible? And maybe it's worth to make a new rollback release of the package? So the latest atom version for Solus will be not the newest one, but at least properly working one?